[Monotone-devel] Updated Issue 113 - commands silently default to :memory: database (monotone)

[code]

Hello,

The following issue has been updated:

113 - commands silently default to :memory: database
Project: monotone
Status: New
Reported by: Timothy Brownawell
URL: http://code.monotone.ca/p/monotone/issues/113/
Labels:
 Type:Incorrect Behavior
 Priority:Medium

Comments (last first):

# By Thomas Keller, Nov 28, 2010:

I agree that :memory: is a bad default, but I wonder if we should (not silently 
of course) default to the db / alias given by the get_default_database_alias 
hook?

# By Timothy Brownawell, Nov 27, 2010:

Steps to reproduce the problem:
-------------------------------

1. make sure you're outside any workspaces
2. run "mtn serve", "mtn ls branches", "mtn pull", etc
3. results are not persistent but do not say "misuse: no database specified", 
for example things pulled do not show up in a later "ls branches"

Expected result:
----------------

Commands should never default to :memory:

Actual results:
---------------

commands *silently* default to :memory:

Output of `mtn version --full`:
-------------------------------

Bisected to:

Revision: 0007c40d9d12137729fdd27c05572f21974d72b7
Parent:   5be91109b5bbc338669cc1f60ebdc99cdc718ab4
Author:   address@hidden
Date:     05/12/2010 07:49:34 AM
Branch:   net.venge.monotone.experiment.database-management

Changelog: 

* use an enum to describe the database type (memory, managed, unmanaged)
* refactor the path resolver for the db out and make it callable elsewhere 
(f.e. from work::set_options)
* set_options needs now a lua_hooks instance, quite a couple of changes therefor
* expand "foo" to "foo.mtn" automatically and always look for "foo.mtn", not 
for "foo"
* open issue: _MTN/options still saves the full path, not the managed one - we 
might want to change that some time



--
Issue: http://code.monotone.ca/p/monotone/issues/113/