[Monotone-devel] Updated Issue 131 - Mingw mtn ssh-agent support should be taught to work with Cygwin ssh-agent (monotone)

[code]

Hello,

The following issue has been updated:

131 - Mingw mtn ssh-agent support should be taught to work with Cygwin ssh-agent
Project: monotone
Status: New
Reported by: Stephen Leake
URL: https://code.monotone.ca/p/monotone/issues/131/
Labels:
 Type:Feature Request
 Priority:Low

Comments (last first):

# By Thomas Keller, Feb 21, 2011:

re-tag, clarify summary

 Labels: Type:Feature Request, -Type:wish
 Summary: Mingw mtn ssh-agent support should be taught to work with Cygwin 
ssh-agent

# By Stephen Leake, Jan 12, 2011:

a little more detail; the current Win32 implementation uses Win32 window 
messages to communicate with the ssh-agent process. The standard ssh-agent uses 
Unix sockets.

# By Stephen Leake, Jan 12, 2011:

Steps to reproduce the problem:
-------------------------------

1. cmd$ ssh-agent bash
2. bash$ mtn ssh_agent_add

Expected result:
----------------
mtn should add private key to running ssh-agent session

Actual results:
---------------
mtn reports 'no ssh-agent is available'

Output of `mtn version --full`: 1.0dev
-------------------------------

this does work with cygwin mtn and cygwin ssh-agent, and with Debian mtn and 
Debian ssh-agent.

The problem is in win32/ssh_agent_platform.cc. It uses Win32 FindWindow to find 
a running instance of "Pageant", which is the ssh-agent for PuTTY, a popular 
implementation of ssh on Windows.

It should also search for the cygwin ssh-agent parent process, using env vars 
SSH_AUTH_SOCK and SSH_AGENT_PID. This requires Unix sockets, which may not be 
available in MinGW.



--
Issue: https://code.monotone.ca/p/monotone/issues/131/