Re: [Nano-devel] Patch for bug #46980

[Benno Schulenberg]

Hello Rishabh,

Thanks for the patch.

Hmm...  Bug numbers don't tell me anything, they don't show
what this is about.  A more significant subject line would
be good.  And you could add a URL of the bug in the message:

    https://savannah.gnu.org/bugs/?46980

On Fri, Jan 29, 2016, at 18:46, Rishabh Dave wrote:
> I passed 'copy_text' variable to 'copy_from_filestruct()' to let it know
> not to change line number while copying (i.e. ALT+6 case). Patch is tested
> over default mode and by using -G, -B switches - all individually. Patch is
> over r5597.
> 
> However, once while I was testing I received 'Segmentation Fault'-error.
> But I did not encounter it again; performing 'MALLOC_CHECK_=2' and valgrind
> check, but couldn't find anything. :\

Well... when you've received a segfault once, things are
wrong /somewhere/.  I will test your patch later; busy with
other things today.

> About the whitespaces (spaces instead of tab), I am sorry. I did not know
> it was so all time along. If I make any such mistakes, I would like to know
> immediately. :)

Well, I was assuming that you would look closely at the
patch or patches I posted, and would learn from observation.

:)

> And... can I receive discussions that happen over email for 'bug#47003:
> memory leak w/position history'? I don't understand memory leaks exactly,
> perhaps I would learn something.

You should make an account on Savannah, login, and then add yourlself
to the (+) Mail Notification Carbon-Copy List near the bottom of a bug page.

Benno

-- 
http://www.fastmail.com - A fast, anti-spam email service.