[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Nano-devel] [PATCH] browser: awkward behaviour when trying to open inac
From: |
Rishabh Dave |
Subject: |
[Nano-devel] [PATCH] browser: awkward behaviour when trying to open inaccessible directory using goto prompt |
Date: |
Tue, 21 Jun 2016 19:17:31 +0530 |
Hi!
Patch for the bug - https://savannah.gnu.org/bugs/?48286 - is attached.
It basically snips code that opens directory under the body of
statement "else if (func == goto_dir_void)" in do_browser() in
browser.c and replaces new_path by newpath around. This makes
new_path's existence redundant so it is removed. Fix for bug #48007:
segmentation fault when trying to browse to an inaccessible directory
would naturally handle it.
I have added a comment and tryed to keep it short but it, to me, looks
imprecise; doesn't capture the fact that newpath could be null. On the
other hand, trying to make it capture that makes the comment long and
fuzzy so I have kept the shorter version.
[I purposefully first submitted a report and then the patch over the
mail, hoping that that helps record-keeping.]
fix-goto-dir-in-browser.patch
Description: Text Data
- [Nano-devel] [PATCH] browser: awkward behaviour when trying to open inaccessible directory using goto prompt,
Rishabh Dave <=
- Re: [Nano-devel] [PATCH] browser: awkward behaviour when trying to open inaccessible directory using goto prompt, Benno Schulenberg, 2016/06/21
- Re: [Nano-devel] [PATCH] browser: awkward behaviour when trying to open inaccessible directory using goto prompt, Rishabh Dave, 2016/06/22
- Re: [Nano-devel] [PATCH] browser: awkward behaviour when trying to open inaccessible directory using goto prompt, Benno Schulenberg, 2016/06/22
- Re: [Nano-devel] [PATCH] browser: awkward behaviour when trying to open inaccessible directory using goto prompt, Rishabh Dave, 2016/06/22
- Re: [Nano-devel] [PATCH] browser: awkward behaviour when trying to open inaccessible directory using goto prompt, Benno Schulenberg, 2016/06/24
- Re: [Nano-devel] [PATCH] browser: awkward behaviour when trying to open inaccessible directory using goto prompt, Rishabh Dave, 2016/06/24
- Re: [Nano-devel] [PATCH] browser: awkward behaviour when trying to open inaccessible directory using goto prompt, Benno Schulenberg, 2016/06/24
- Re: [Nano-devel] [PATCH] browser: awkward behaviour when trying to open inaccessible directory using goto prompt, Rishabh Dave, 2016/06/24
- Re: [Nano-devel] [PATCH] browser: awkward behaviour when trying to open inaccessible directory using goto prompt, Benno Schulenberg, 2016/06/24
- Re: [Nano-devel] [PATCH] browser: awkward behaviour when trying to open inaccessible directory using goto prompt, Rishabh Dave, 2016/06/25