Re: [Nano-devel] [PATCH] various color tweaks

[Benno Schulenberg]

Op 03-03-18 om 02:22 schreef Brand Huntsman:
> The first patch might reduce memory on 64bit platforms.

I'm not much interested in reducing the memory usage of nano.
Nano uses shitloads of memory anyway, reading in *all* of the
syntaxes (some distros do that by default).

> +             (beforenow->attributes & 0xFFFF0000) !=
> +                     ink->attributes))

It is unclear what this does.  Apparently you have figured out that
actual attributes, like A_BOLD and A_REVERSE, live in the upper 32 bits
of the color thingy.  But is that true also for older ncurses?  Didn't
it limit color pairs and attributes to 16 bits each?

> Subject: [PATCH 2/5] refactor parse_color_names() function
> 
> Default foreground and background color is available as ",".
>       color , "regex"
>       set titlecolor ,

To make the title bar indistinguishable from normal text doesn't seem
very useful.  But to be able to give back the normal color to text
that has been unavoidably colored by earlier regexes, seems nice.

>  src/rcfile.c | 48 +++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 35 insertions(+), 13 deletions(-)

Well, refactoring is good -- when it reduces the number of lines,
or when it makes the code clearer at the cost of just a few lines.

Benno

signature.asc
Description: OpenPGP digital signature