Re: [Nano-devel] [PATCH 3/3] filtering: pair the cut and the insert, so they can be undone together

[Benno Schulenberg]

Op 21-05-18 om 23:46 schreef Marco Diego Aurélio Mesquita:
> On Mon, May 21, 2018 at 6:36 PM, Marco Diego Aurélio Mesquita
> <address@hidden> wrote:
>> Found a bug. How to reproduce it:
>>
>> ./src/nano README
>>
>> Mark the lines 27 to 32 (inclusive). Press ^R^XM-\M-Fcat^MM-U^XM-U

Superb!  I never noticed that, when undoing the insertion in the
second buffer, it said on the status bar "Nothing to undo".  :|

So you see: just another pair of eyes helps a lot.  Thanks!

> Quick solution: the calls to add_undo and update_undo in
> execute_command should be conditioned by !ISSET(MULTIBUFFER).
> 
> The change seems to fix the problem here. Benno, do you agree with it?

Yes -- these undo items should only be added when doing a real cut
(that is: when doing the filtering in the buffer itself), not when
doing a copy (when sending the filtered stuff to a new buffer).

Thanks for the fix.  I have arranged the things a bit differently,
though -- see the upcoming patch set.  I've also elided the pipe_tag
from the first patch, as it was used only once.

Benno

signature.asc
Description: OpenPGP digital signature