[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V3] input: allow distinguishing shifted from unshifted Meta k
|
From: |
Benno Schulenberg |
|
Subject: |
Re: [PATCH V3] input: allow distinguishing shifted from unshifted Meta keystrokes |
|
Date: |
Sun, 15 Dec 2019 11:36:57 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
Op 14-12-2019 om 03:29 schreef Brand Huntsman:
> You can't just cast the const away and hope it works, it doesn't. The const is
> there because keystr can hold string literals, and literals are stored in a
> readonly segment on systems with the slightest bit of security. Did it
> actually work on yours?
It worked when I briefly tested it after compiling it with gcc.
Now it segfaults. :| Both with gcc and clang.
> The tolower() needs to allocate and copy keystr before modifying it.
I see.
Benno
signature.asc
Description: OpenPGP digital signature