[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] input: read in an external paste in one go, to allow und
|
From: |
Benno Schulenberg |
|
Subject: |
Re: [PATCH 1/2] input: read in an external paste in one go, to allow undoing with one M-U |
|
Date: |
Sun, 19 Jan 2020 11:37:57 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
Op 17-01-2020 om 23:46 schreef Brand Huntsman:
> On Fri, 17 Jan 2020 17:02:31 +0100
> Benno Schulenberg <address@hidden> wrote:
>
>> + } else if ((input > 0x1F && input <= 0xFF &&
>
> Looks good, but why not use ">= 0x20" to make it easier to read?
Normally I try to avoid >= and <=. But I didn't like the look of "< 0x100",
so I used "<= 0xFF" instead. But I agree that the asymmetry does not look
nice... Okay, will change to ">= 0x20".
(Note, by the way, that this filtering of control codes is imperfect: it
does not filter out the high UTF-8 (C1) control codes. But getting that
right is something for another time.)
Benno
signature.asc
Description: OpenPGP digital signature