[Net::FTPServer] Fwd: Net::FTPServer bugs

[Richard Jones]

----- Forwarded message from Simon Strack <address@hidden> -----

Subject: Net::FTPServer bugs
From: Simon Strack <address@hidden>
To: address@hidden
Organization: Monash University

Hi Richard,

I've found a couple of bugs in 1.120, both in FTPServer.pm

1.
A  variable name seems to be only partially migrated to the new name.
$self->{client_log} -> $self->{_client_log}

2.
The check introduced for the error log file name, to see if the variable 
was defined, needs to also happen for the client log and the xfer log.

I've attached a diff.

SiMoN


--- FTPServer.pm.old    2005-07-15 14:14:36.555026050 +1000
+++ FTPServer.pm        2005-07-15 14:10:00.380021175 +1000
@@ -3149,7 +3149,8 @@
     my $self = shift ;
     if ( my $log_file = $self->config("xfer logging") ) {
       $log_file = $self->resolve_log_file_name($log_file) ;
-      if ( $log_file ne $self->{_xfer_file} ) {
+      if ( !defined $self->{_xfer_file} ||
+          $log_file ne $self->{_xfer_file} ) {
        if ( my $io = $self->{_xferlog} ) {
          $io->close ;
          delete $self->{_xferlog} ;
@@ -3173,7 +3174,8 @@
     my $self = shift ;
     if ( my $log_file = $self->config("client logging") ) {
       $log_file = $self->resolve_log_file_name($log_file) ;
-      if ( $log_file ne $self->{_client_file} ) {
+      if (!defined $self->{_client_file} ||
+          $log_file ne $self->{_client_file} ) {
        if ( my $io = $self->{_client_log} ) {
          $io->close ;
          delete $self->{_client_log} ;
@@ -3207,9 +3209,9 @@
 sub _log_line
   {
     my $self = shift;
-    return unless exists $self->{client_log};
+    return unless exists $self->{_client_log};
     my $message = join ("",@_);
-    my $io = $self->{client_log};
+    my $io = $self->{_client_log};
     my $time = scalar localtime;
     my $authenticated = $self->{authenticated} ? $self->{user} : "-";
     $message =~ s/\n*$/\n/;


----- End forwarded message -----

-- 
Richard Jones, CTO Merjis Ltd.
Merjis - web marketing and technology - http://merjis.com
Team Notepad - intranets and extranets for business - http://team-notepad.com