[Net::FTPServer] Re: Net::FTPServer patches

[Richard Jones]

On Tue, Aug 18, 2009 at 01:58:04PM +1000, Bron Gondwana wrote:
> Hi Richard,
> 
> Are you still maintaining Net::FTPServer?  I see it hasn't had an
> update since 2005!

Hi, yes, it's just very stable.

I've CC'd this to the mailing list.

Rich.

> I'm running it at FastMail for our FTP server, but with a small
> collection of patches that's slowly growing bigger!  I keep my
> changes in git at:
> 
> http://github.com/brong/brong-netftpserver/
> 
> As you can see, I've added a few interesting little bits and
> pieces:
> 
> * SSL support
> * SITE UTIME / MDTM support
> * bandwidth tracking hooks
> * custom login response
> 
> And I'm planning just now to go and fix all the ->log statements
> to use sprintf syntax on untrusted user input so that users
> can't inject random % crap (our log is full of the following):
> 
> Invalid conversion in sprintf: "%^" at /usr/lib/perl/5.10/Sys/Syslog.pm line 
> 334, <GEN4370> line 6.
> Invalid conversion in sprintf: "%^" at /usr/lib/perl/5.10/Sys/Syslog.pm line 
> 334, <GEN10226> line 6.
> Invalid conversion in sprintf: "%^" at /usr/lib/perl/5.10/Sys/Syslog.pm line 
> 334, <GEN10228> line 6.
> 
> I'd love to push this back upstream for everyone else's benefit.
> I've signed up as 'brong' on Savannah if you want to add me to
> the project there if that helps, or feel free to cherry-pick
> from my git repository.
> 
> Regards,
> 
> Bron.

-- 
Richard Jones
Red Hat