Re: [Nmh-workers] [patch] gcc warnings: possible use of uninitialized data

[Peter Maydell]

Peter Maydell wrote:
>>>--- a/uip/inc.c      Fri Nov 05 10:56:54 2010 -0300
>>>+++ b/uip/inc.c      Fri Nov 05 16:36:28 2010 -0300

>>NAK. This seems to be a rather large function which is using
>>'i' as a "did we hit an error?" flag to see whether we should
>>take an error-exit path at the end. 
>
>This I haven't addressed (yet) because the compiler I'm using
>doesn't complain about this function. I do have an untested
>patch to address it lurking on another machine somewhere.

I've now finished, tested and committed the cleanup I had in
mind:
http://git.savannah.gnu.org/cgit/nmh.git/commit/?id=0ce746a6f

(Incidentally I'm happy to send these cleanup patches to the
list to review first if people would prefer that. I'd definitely
put more significant changes out for review first anyway...)

-- PMM