Re: [Nmh-workers] [exmh-workers] Second release candidate for nmh1.5 is now available

[Kevin Cosgrove]

On 7 May 2012 at 9:49, David Levine <address@hidden>wrote:

> > I'm building and packaging this.  This part of the 'make install'
> >
> >   chgrp mail /buildroot/nmh-1.5-1kc_0tek_RC2_fc16.x86_64/usr/bin/inc && \
> >   chmod 2755 /buildroot/nmh-1.5-1kc_0tek_RC2_fc16.x86_64/usr/bin/inc; \
> >
> > requires the builder to belong to the "mail", which won't be the case
> > when I try to install this on my computer at work.
> 
> It looks like this is on Linux.  If you add --with-locking=fcntl
> to your configure,

My .spec file looks like this for configure:

CFLAGS="$RPM_OPT_FLAGS -fno-builtin-strcasecmp"
%configure \
            --sysconfdir=%{_sysconfdir}/nmh \
            --libdir=%{_libexecdir}/nmh \
            --with-locking=fcntl \
            --enable-pop

That translates into this in my build log file:

+ CONFIGURE_XPATH='--x-includes=/usr/local/include --x-libraries=/usr/local/lib'
+ ./configure i586-mandriva-linux-gnu --program-prefix= --prefix=/usr/local 
--exec-prefix=/usr/local --bindir=/usr/local/bin --sbindir=/usr/local/sbin 
--sysconfdir=/usr/local/etc/nmh --datadir=/usr/local/share 
--includedir=/usr/local/include --libdir=/usr/local/lib 
--libexecdir=/usr/local/libexec --localstatedir=/usr/local/var 
--sharedstatedir=/usr/local/com --mandir=/usr/local/share/man 
--infodir=/usr/local/share/info --x-includes=/usr/local/include 
--x-libraries=/usr/local/lib --sysconfdir=/usr/local/etc/nmh/nmh 
--libdir=/usr/local/libexec/nmh --with-locking=fcntl --enable-pop

> then the install won't try to chgrp/chmod.

Later in the make install step I see this:

if test x != x; then \
                chgrp mail 
/var/tmp/rpm/nmh-1.5-4kc_0tek_RC2_mdv2007.0-buildroot-/usr/local/bin/inc && \
                chmod 2755 
/var/tmp/rpm/nmh-1.5-4kc_0tek_RC2_mdv2007.0-buildroot-/usr/local/bin/inc; \
        fi

> On Linux, fcntl locking should be used anyway.  The Fedora RPM
> build does.

I think I specified that with "--with-locking=fcntl" in the
configure step.

> > FWIW, Fedora has undone the special treatment of the 'inc' file.

I started with a Fedora src.rpm, which contains this line right
after the make install.

   chmod g-s $RPM_BUILD_ROOT/%{_bindir}/inc

That's what I was referring to

> Right, using fcntl locking.

Maybe that too.

> Have you looked at docs/contrib/nmh.spec?  It's intended to be
> generic.

Yes.  I looked at that.  It's about the same as the Fedora src.rpm's 
spec file.  Neither is far from my own spec file, which is just a 
salted version of the Fedora spec file.

> I just noticed that it has --enable-pop, which is obsolete.  I'll
> remove that.

I'll follow your lead and do that as well.

Thanks....

--
Kevin