Re: [Nmh-workers] hooks interface issues

[Ken Hornstein]

>The bigger problem of course is that nmh reports a failure to
>invoke the hook. It does not function in either version I have,
>and so it would not seem to be a recent breakage, unless my
>simple test is not doing something the hooks expect e.g; a
>specific return value, although there don't seem to be any such
>checks.

I see two issues:

- The fact that it thinks hook is NULL.  That seems like a bug, and I'll
  be honest; I don't know what's happening there.

  Ah, okay, THAT is being caused by this code:

    if (status != OK) {
        if (did_message == 0) {
            if ((hook = context_find("msg-hook")) != (char *)0)
                advise(NULL, hook);
            else
                advise(NULL, "external hook (%s) did not work properly.", hook);
        

  Calling context_find() AGAIN is resetting hook to NULL.  Looks like that bug
  has been in there since day 1.  I verified that hook is being set to the
  correct thing.

- So ... it looks like the child is failing with ... SIGTRAP?  No, maybe that's
  because I'm running it under the debugger.  The hooks interface doesn't
  use pidstatus(), so this needs a closer look to see what's going wrong.

And, I have to ask ... 1.3?  You're not the only person still using that,
so I'm wondering if I did something wrong, or you just haven't seen a reason
to upgrade yet.

--Ken