[Octave-bug-tracker] [bug #29553] missing arpack: make check segfaults on eigs

[Petr Mikulik]

Follow-up Comment #19, bug #29553 (project octave):

File eigs.cc still contains testing code block which does nothing unless
Octave is compiled with arpack:

%!shared n, k, A, d0, d2
%! n = 20;
%! k = 4;
%! A =
sparse([3:n,1:n,1:(n-2)],[1:(n-2),1:n,3:n],[ones(1,n-2),4*ones(1,n),ones(1,n-2)]);
%! d0 = eig (A);
%! d2 = sort (d0);
%! [~, idx] = sort (abs(d0));
%! d0 = d0(idx);

There is no assert() command afterwards, thus these commands are useless.

I think the whole test code should be in %!testif HAVE_ARPACK,

%% Real positive definite tests, n must be even
%!testif HAVE_ARPACK
%! shared n, k, A, d0, d2
%! n = 20;
%! k = 4;
%! d1 = eigs (A, k);
...

instead of tens of
%!testif HAVE_ARPACK
%! d1 = eigs (A, k);
%! assert (d1, d0(end:-1:(end-k+1)), 1e-11);



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?29553>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/