[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #43118] Missing function lscov
From: |
Pantxo Diribarne |
Subject: |
[Octave-bug-tracker] [bug #43118] Missing function lscov |
Date: |
Fri, 05 Sep 2014 09:05:12 +0000 |
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 |
Follow-up Comment #1, bug #43118 (project octave):
Hi Nir,
I have no expertise in this kind of algorithm but I can make a few formal
proposals. I have attached a modified version of your function with the
following mods:
* add space between function names and parens to visually differentiate
function calls and matrix indexing,
* reduce indentation to 2 spaces,
* enclose boolean expressions after "if" statements between parens,
* add "endfunction" before tests,
* add a few input checkings so that calling the function e.g. "lscov (1)"
returns a useful error message,
Finally I also reorganized the doc so that it looks more like other octave
functions help:
* list the different ways to call the function in the header, so that it is
obvious what input parameter is optional or not,
* remove the input/output sections in favor of dedicated paragraphs. As an
example of a function that have a similar interface, see the help string for
"fsolve" function.
Can you tell me if you agree with my proposal?
(file #32028)
_______________________________________________________
Additional Item Attachment:
File name: lscov.m Size:6 KB
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?43118>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-bug-tracker] [bug #43118] Missing function lscov,
Pantxo Diribarne <=
- [Octave-bug-tracker] [bug #43118] Missing function lscov, Nir Krakauer, 2014/09/05
- [Octave-bug-tracker] [bug #43118] Missing function lscov, Pantxo Diribarne, 2014/09/06
- [Octave-bug-tracker] [bug #43118] Missing function lscov, Nir Krakauer, 2014/09/06
- [Octave-bug-tracker] [bug #43118] Missing function lscov, Pantxo Diribarne, 2014/09/07
- [Octave-bug-tracker] [bug #43118] Missing function lscov, Nir Krakauer, 2014/09/07
- [Octave-bug-tracker] [bug #43118] Missing function lscov, Pantxo Diribarne, 2014/09/07
- [Octave-bug-tracker] [bug #43118] Missing function lscov, Nir Krakauer, 2014/09/07
- [Octave-bug-tracker] [bug #43118] Missing function lscov, Pantxo Diribarne, 2014/09/08