[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #36372] Improved ranks.m included:
From: |
Lachlan Andrew |
Subject: |
[Octave-bug-tracker] [bug #36372] Improved ranks.m included: |
Date: |
Thu, 03 Dec 2015 23:40:30 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110422 Ubuntu/8.04 (hardy) Firefox/3.6.17 |
Follow-up Comment #17, bug #36372 (project octave):
Dave, I like your new algorithms. They're very elegant. Even ignoring the
performance improvement, I think that the reduced complexity is worthwhile.
The algorithm is also better with memory locality; I ran it on a machine with
512M, and the original ranks.m thrashes and takes 100 seconds to run even when
dim=1, whereas the new one runs in a under 4 seconds.
I have:
1) tidied the code a little (in particular, it now takes the tie-break rule
"rtype" as a third parameter, rather than as an element of a structure);
2) put it in Octave's coding style (as I understand it); and
3) made it a Mercurial change-set relative to the current development
version.
If anyone wants to check the style, or test the code, feel free. However, I
think the patch is ready to apply.
(file #35638)
_______________________________________________________
Additional Item Attachment:
File name: bug_36372-ranks-patch.txt Size:6 KB
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?36372>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-bug-tracker] [bug #36372] Improved ranks.m included:,
Lachlan Andrew <=