[Octave-bug-tracker] [bug #48807] gsvd function needs BIST tests updated

[Carnë Draug]

Follow-up Comment #16, bug #48807 (project octave):

Yes, it is usable but this is not the right fix. I think that if we didn't had
the incomplete gsvd already in the repository and someone submitted as it is,
we wouldn't accept it and would ask the submitter to do it correctly without
those issues. But we still don't have to accept it. gsvd has not been released
in any Octave version yet so we can just revert the changes and do it properly
later.

This was my mistake, I should have tested gsvd better and check Matlab
compatibility before merging. If it was not in the repo, and I were to add it
now to core in this state, would it really be accepted?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48807>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/