[Octave-bug-tracker] [bug #51203] [octave-forge] (io) xlsopen/xlsclose may create spurious files/folders instead of .xlsx file with "OCT" interface

[Philip Nienhuis]

Update of bug #51203 (project octave):

                  Status:         Patch Submitted => Need Info              

    _______________________________________________________

Follow-up Comment #76:

@Markus
sorry for long delay, after returning from vacation there were (and still are)
other (private) distractions keeping me busy.

I went through your patch of comment #74 and have some Q. (line numbers are
those of the patch):

__OCT_spsh_close__.m
0 Where is variable adddToFile (L.23) used?

0 What is the use of hunk L.30-35?

__OCT_spsh_open__.m
-------------------
0 What is the use of variable i_open in L.76? It is nowhere used

0 Why do you want:

-    fid = fopen (sprintf ('%s/xl/workbook.xml', tmpdir));

to be changed by

+    workbook_xml = sprintf ('%s/xl/workbook.xml', tmpdir);
+    fid = fopen (workbook_xml);

It merely introduces a temporary variable that is nowhere used anymore.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51203>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/