[Octave-bug-tracker] [bug #51871] loading '-ascii' format files is slow

[Dan Sebald]

Follow-up Comment #36, bug #51871 (project octave):

Just wondering if here:


+      // Error during conversion.
+      if (str_chunk.size () >= 2
+          && std::toupper (str_chunk[0]) == 'N'
+          && std::toupper (str_chunk[1]) == 'A')
+        {
+          // Found NA
+          val = octave::numeric_limits<T>::NA ();
+          end_ptr += 2;
+        }


the test should have "str_chunk.size() == 2" because otherwise this test would
pass for things like NATION, NASCENT, etc.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51871>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/