[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #54952] optimset (old, new) uses empty fields
From: |
Kai Torben Ohlhus |
Subject: |
[Octave-bug-tracker] [bug #54952] optimset (old, new) uses empty fields from 'new' |
Date: |
Fri, 7 Dec 2018 16:38:56 -0500 (EST) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.80 Safari/537.36 |
Update of bug #54952 (project octave):
Status: Fixed => Patch Reviewed
Open/Closed: Closed => Open
_______________________________________________________
Follow-up Comment #8:
Never mind, how can earning money be a fault? Octave development is
professional hobby, right? ;-)
Olaf, your cset (file #45592) works fine with me: bug #55089 remains fixed,
no other errors test bench observed. I would only rather refer to this bug,
than to bug #55089 in the commit message. Please go ahead and push it.
Not only because I made the changes, I vote to keep the changes of comment #6.
The options of each solver are kind of constant (except for the user to
change them inside the m-files). There is simply no need to verify them at
each and every call.
By reverting it, we obtain back a fragile (in the sense that errors are easily
introduced, if this mechanism is not understood bug #55089) circle as
explained before: "optimset" calls "__all_options__" that calls "fminunc" that
calls "optimset" to verify its constants.
As protection against "bad" constants, we already have this one and works fine
with an error at Octave startup:
https://hg.savannah.gnu.org/hgweb/octave/file/0a862644da84/scripts/optimization/__all_opts__.m#l62
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?54952>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/