[Octave-bug-tracker] [bug #55741] build with '-Woverloaded-virtual' emits many warnings indicating problems

[Andrew Janke]

Follow-up Comment #6, bug #55741 (project octave):

I'm seeing a couple additional warnings with clang on macOS 10.14.3 / Xcode
10.1.


In file included from ../../octave/libinterp/corefcn/fcn-info.h:36:
../../octave/libinterp/corefcn/symscope.h:120:16: warning: expression result
unused [-Wunused-value]
      new_sid->m_name;
      ~~~~~~~  ^~~~~~
[...]
In file included from ../../octave/libgui/src/octave-qt-link.h:37:
../../octave/libgui/src/octave-gui.h:54:9: warning: private field 'm_argc' is
not used [-Wunused-private-field]
    int m_argc;
        ^
../../octave/libgui/src/octave-gui.h:55:12: warning: private field 'm_argv' is
not used [-Wunused-private-field]
    char **m_argv;
           ^
2 warnings generated.


These look like things that should actually be fixed.

I can't tell if that `new_sid->m_name;` should actually be `new_sid->m_name =
m_name;` or not.

Looks like the unused private fields can, by definition, be removed.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55741>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/