|
| From: | Markus Mützel |
| Subject: | [Octave-bug-tracker] [bug #55908] Closing plots much slower in Octave 5.1.0 |
| Date: | Sat, 16 Mar 2019 17:30:21 -0400 (EDT) |
| User-agent: | Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0 |
Follow-up Comment #6, bug #55908 (project octave):
Thanks for bisecting.
The problem seems to be that calling the remove_children callbacks is slow.
But it isn't necessary to call these functions if the figure is going to be
closed anyway (I think).
The attached patch skips executing the remove_children callbacks in that case.
The time for closing the figure from the example in comment #0 reduces from
just above 10 seconds to about 10 milliseconds for me.
Further testing is still necessary.
(file #46561)
_______________________________________________________
Additional Item Attachment:
File name: bug55908_delete_from_groot.patch Size:11 KB
<https://savannah.gnu.org/file/bug55908_delete_from_groot.patch?file_id=46561>
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?55908>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
| [Prev in Thread] | Current Thread | [Next in Thread] |