[Octave-bug-tracker] [bug #56505] setting CXX should affect mkoctfile link stage as well

[Mike Miller]

Follow-up Comment #5, bug #56505 (project octave):

I looked at and tested what you have so far.

The biggest thing I notice is that CXXLD is an Automake variable, not an
Autoconf variable, so referencing it in configure.ac will always evaluate to
an empty string.

I think maybe we should eliminate CXXLD and MKOCTFILE_CXXLD entirely from
configure.ac, and instead push the logic into mkoctfile.in.cc itself, that
CXXLD should be set to the value of OCTAVE_CONF_MKOCTFILE_CXX by default.

I honestly have no idea about the NetBSD and SunOS cases, maybe we should just
drop those overrides and wait for complaints.

Overall, now that I see how Automake initializes CXXLD normally, I think we
should avoid adding that variable to configure, but I still think the name
makes sense for mkoctfile to use for its own purposes.

I also saw you had a few lines with trailing whitespace.

I put my suggestions into an updated version of your patch file, attached, and
testing now.

(file #47545)
    _______________________________________________________

Additional Item Attachment:

File name: mkoctfile-v2.patch             Size:21 KB
    <https://savannah.gnu.org/file/mkoctfile-v2.patch?file_id=47545>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?56505>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/