|
| From: | Mike Miller |
| Subject: | [Octave-bug-tracker] [bug #57754] Back out App Nap objc_msgSend fix on Mojave+ |
| Date: | Thu, 6 Feb 2020 19:21:02 -0500 (EST) |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.87 Safari/537.36 |
Follow-up Comment #2, bug #57754 (project octave):
I think the conditional would be better written as a single line as
#if defined (__MAC_OS_X_VERSION_MAX_ALLOWED) && __MAC_OS_X_VERSION_MAX_ALLOWED
< 101400
to generally agree with our preprocessor code style (grep for
"#.*if.*defined.*[<>]").
We also generally prefer behavior tests to version comparisons, is it possible
to write a configure compile test that would fail on systems where this no
longer works?
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?57754>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
| [Prev in Thread] | Current Thread | [Next in Thread] |