[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #57439] handles to private functions may fail
From: |
Markus Mützel |
Subject: |
[Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions" |
Date: |
Sun, 9 Feb 2020 06:26:18 -0500 (EST) |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0 |
Follow-up Comment #13, bug #57439 (project octave):
I'm not sure if supporting UNC paths alters the definition of
canonicalize_file_name. I can't find a reference to the fact that it only
works for local files on its man page. [1]
Also, the std::filesystem library (C++17) adds std::filesystem::canonical [2].
Reading on (e.g. the definition of "root-name" here [3]), I'd understand that
it works on UNC paths, too.
Maybe, we could replace gnulib's canonicalize_file_name with the standard
function std::filesystem::canonical at some point in the future. With respect
to UNC paths, that wouldn't lead to much change in behavior now.
I agree that the special case I introduced in my last change could be
improved. But I hope it is good enough until when we allow using C++17
functions (if we decide to do that).
Alternatively, we could introduce a new function that behaves more along the
lines of std::filesystem::canonical. But I think the differences would be so
small that it would only cause confusion.
[1]: http://man7.org/linux/man-pages/man3/canonicalize_file_name.3.html
[2]: https://en.cppreference.com/w/cpp/filesystem/canonical
[3]: https://en.cppreference.com/w/cpp/filesystem/path
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?57439>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions", Rik, 2020/02/03
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions", John W. Eaton, 2020/02/03
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions", Markus Mützel, 2020/02/04
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions", Markus Mützel, 2020/02/08
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions", Markus Mützel, 2020/02/08
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions", Mike Miller, 2020/02/08
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions",
Markus Mützel <=
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions", Philip Nienhuis, 2020/02/11
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions", Philip Nienhuis, 2020/02/17
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions", Markus Mützel, 2020/02/18
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions", Dmitri A. Sergatskov, 2020/02/18
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions", Markus Mützel, 2020/02/21
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions", Philip Nienhuis, 2020/02/21
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions", Markus Mützel, 2020/02/23
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions", Philip Nienhuis, 2020/02/23
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions", John W. Eaton, 2020/02/26
- [Octave-bug-tracker] [bug #57439] handles to private functions may fail after "clear functions", Philip Nienhuis, 2020/02/26