[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #57658] [MXE Octave] grey text color after mko
From: |
Kai Torben Ohlhus |
Subject: |
[Octave-bug-tracker] [bug #57658] [MXE Octave] grey text color after mkoctfile error message in gui terminal widget |
Date: |
Mon, 17 Feb 2020 00:39:47 -0500 (EST) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.106 Safari/537.36 |
Update of bug #57658 (project octave):
Status: In Progress => Need Info
_______________________________________________________
Follow-up Comment #16:
pkg is indeed sneaking around Octave's convenience wrapper by calling make
directly.
https://hg.savannah.gnu.org/hgweb/octave/file/eb46a9f47164/scripts/pkg/private/configure_make.m#l94
Unless there are more spots like this in Octave, I propose the following
additional patch:
diff -r 75a90bfc14b1 scripts/pkg/private/configure_make.m
--- a/scripts/pkg/private/configure_make.m Fri Jan 31 10:45:13 2020 -0800
+++ b/scripts/pkg/private/configure_make.m Mon Feb 17 14:29:37 2020 +0900
@@ -57,6 +57,11 @@ function configure_make (desc, packdir,
cenv = {"MKOCTFILE"; mkoctfile_program;
"OCTAVE_CONFIG"; octave_config_program;
"OCTAVE"; octave_binary};
+ if (ispc () && isguirunning ())
+ ## FIXME: Remove this branch when the MS Windows GUI terminal widget
can
+ ## properly handle colors (bug #57658).
+ cenv = [cenv; {"CXXFLAGS"; "-fdiagnostics-color=never"}];
+ endif
scenv = sprintf ("%s='%s' ", cenv{:});
## Configure.
It works at least on my MS Win 10 VM.
We stay on m-code. Anyone can easily test gcc colors by removing the code.
On mkoctfile.cc level we have no change to detect if a running GUI called the
program. Thus the decision has to be made to forbid colors in MS Windows
entirely. This I find a pity, since in the terminal they look great.
Unfortunately for Octave 5.2.0 it is too late but for Octave 6 it can get in
easily.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?57658>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #57658] [MXE Octave] grey text color after mkoctfile error message in gui terminal widget, John Donoghue, 2020/02/14
- [Octave-bug-tracker] [bug #57658] [MXE Octave] grey text color after mkoctfile error message in gui terminal widget,
Kai Torben Ohlhus <=
- [Octave-bug-tracker] [bug #57658] [MXE Octave] grey text color after mkoctfile error message in gui terminal widget, Mike Miller, 2020/02/17
- [Octave-bug-tracker] [bug #57658] [MXE Octave] grey text color after mkoctfile error message in gui terminal widget, Kai Torben Ohlhus, 2020/02/17
- [Octave-bug-tracker] [bug #57658] [MXE Octave] grey text color after mkoctfile error message in gui terminal widget, John Donoghue, 2020/02/17
- [Octave-bug-tracker] [bug #57658] [MXE Octave] grey text color after mkoctfile error message in gui terminal widget, Kai Torben Ohlhus, 2020/02/17
- [Octave-bug-tracker] [bug #57658] [MXE Octave] grey text color after mkoctfile error message in gui terminal widget, John Donoghue, 2020/02/17
- [Octave-bug-tracker] [bug #57658] [MXE Octave] grey text color after mkoctfile error message in gui terminal widget, John Donoghue, 2020/02/17
- [Octave-bug-tracker] [bug #57658] [MXE Octave] grey text color after mkoctfile error message in gui terminal widget, John Donoghue, 2020/02/17
- [Octave-bug-tracker] [bug #57658] [MXE Octave] grey text color after mkoctfile error message in gui terminal widget, John Donoghue, 2020/02/17
- [Octave-bug-tracker] [bug #57658] [MXE Octave] grey text color after mkoctfile error message in gui terminal widget, Nicholas Jankowski, 2020/02/18
- [Octave-bug-tracker] [bug #57658] [MXE Octave] grey text color after mkoctfile error message in gui terminal widget, John Donoghue, 2020/02/21