|
| From: | Nicholas Jankowski |
| Subject: | [Octave-bug-tracker] [bug #57867] strrep: unexpected substitution behavior on a char array |
| Date: | Tue, 21 Apr 2020 22:12:38 -0400 (EDT) |
| User-agent: | Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.113 Safari/537.36 |
Follow-up Comment #54, bug #57867 (project octave):
yes, it appears you are now following the correct procedures to produce a
patch from the latest version of the source.
the other comments were about the actual function:
- adherence to coding style
- the behavior of the function to maintain compatibility
- Mike's comments about what the output of the function should be.
- comments about the new function still passing the tests for behavior that
should still occur.
- comments about new tests to ensure the new patch performs the new function.
In general, you should never upload a file without a Discussion Comment up
here describing what was done. this should be a conversation about the work
being done. It's easier to stay on an agreed path and avoid wasting effort
that way.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?57867>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
| [Prev in Thread] | Current Thread | [Next in Thread] |