[Octave-bug-tracker] [bug #58181] MATLAB function getpixelposition() missing

[Rik]

Update of bug #58181 (project octave):

                  Status:         Patch Submitted => Fixed                  
             Open/Closed:                    Open => Closed                 
                 Release:                   5.2.0 => dev                    

    _______________________________________________________

Follow-up Comment #5:

I reviewed the patch and made a few small changes:

1) I wrote the error messages in the affirmative ("H is not a graphics handle"
-> "H must be a graphics handle")

2) Announced the new function in the NEWS file

3) Changed input parameter "recursive" to "rel_to_fig" because I think it is
clearer than Matlab's name.

4) Broke out the input validation for H being a scalar graphics handle and it
now emits an error with a specific message ("H must be a scalar graphics
handle") rather than calling print_usage() which is generic.

5) Added BIST tests for input validation.

Checked everything in here:
https://hg.savannah.gnu.org/hgweb/octave/rev/be3dab3212e9.

Marking as fixed and closing report.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?58181>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/