[Octave-bug-tracker] [bug #57081] [octave forge] (io) incorrect io package version in src/configure.ac

[Kai Torben Ohlhus]

Follow-up Comment #5, bug #57081 (project octave):

Dear Philip, I am a happy user of your io package for long time 🙂

Please find attached the desired patch to makes things hopefully easier
again.

In general the idea is to make your package code Octave 4.4+ compatible and
the header looks like this


#if ! defined (OCTAVE_4_2_COMPATIBILITY_H_)
#define OCTAVE_4_2_COMPATIBILITY_H_ 1

#include <octave/version.h>

#if OCTAVE_MAJOR_VERSION == 4 && OCTAVE_MINOR_VERSION < 4
  #define iscell    is_cell
  #define isempty   is_empty
  #define isnumeric is_numeric
#endif

#endif


The only affected Octave versions are 4.2 >= VER > 4.4.  Because the "iscell"
-> "is_cell" change was made for Octave 4.4 and you claim to support the
Octave 4.2 series, which I fully understand.

I tested my patch in Octave 5.2.0 and 4.4.1.  To my shame I must admit to not
have an Octave 4.2 ready to go now.  But I can prepare one if necessary.

Once you drop support for Octave 4.2, just burn my header and the three
includes of them 😅

Please let me know about the patch =)


(file #49733)
    _______________________________________________________

Additional Item Attachment:

File name: of-io-no-bootstrap.patch       Size:10 KB
   
<https://file.savannah.gnu.org/file/of-io-no-bootstrap.patch?file_id=49733>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57081>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/