|
| From: | Markus Mützel |
| Subject: | [Octave-bug-tracker] [bug #59192] unwind_protect objects should be replaced with lighter weight alternatives |
| Date: | Mon, 28 Sep 2020 14:24:50 -0400 (EDT) |
| User-agent: | Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.121 Safari/537.36 Edg/85.0.564.63 |
Follow-up Comment #11, bug #59192 (project octave):
I tried to take a stab at graphics.cc. See the attached patch.
There are two places where unwind_protect is used where I don't know how to
replace it easily:
https://hg.savannah.gnu.org/hgweb/octave/file/d28016d16e9a/libinterp/corefcn/graphics.cc#l3727
octave::unwind_protect frame;
interpreter_try (frame);
And Fdrawnow which seems to be a real life example of what jwe wrote in
comment #10:
https://hg.savannah.gnu.org/hgweb/octave/file/d28016d16e9a/libinterp/corefcn/graphics.cc#l13837
(file #49878)
_______________________________________________________
Additional Item Attachment:
File name: bug59192_graphics.cc.patch Size:6 KB
<https://file.savannah.gnu.org/file/bug59192_graphics.cc.patch?file_id=49878>
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?59192>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
| [Prev in Thread] | Current Thread | [Next in Thread] |