[Octave-bug-tracker] [bug #59431] [octave forge] (nan) src/Makefile does not honour CPPFLAGS from environment

[Rafael Laboissiere]

URL:
  <https://savannah.gnu.org/bugs/?59431>

                 Summary: [octave forge] (nan) src/Makefile does not honour
CPPFLAGS from environment
                 Project: GNU Octave
            Submitted by: rlaboiss
            Submitted on: Sat 07 Nov 2020 09:01:48 PM UTC
                Category: Octave Forge Package
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Other
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: other
         Discussion Lock: Any
        Operating System: GNU/Linux

    _______________________________________________________

Details:

The CPPFLAGS from the environment is not honored by src/Makefile.  

In lines 63 to 65 of src/Makefile.in, there is this code:


# Support Debian Hardening flags
#
https://wiki.debian.org/HardeningWalkthrough#Handling_dpkg-buildflags_in_your_upstream_build_system
CFLAGS += $(CPPFLAGS)


This is great, but useless, because there is the following code in line 128:


CFLAGS := -fexceptions -fPIC -fno-omit-frame-pointer -pthread


In order to honor the dpkg-buildflags environment in a Debian system, it is
necessary to apply the patch attached to this bug report.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 07 Nov 2020 09:01:48 PM UTC  Name:
honour-cppflags-from-environment.patch  Size: 614B   By: rlaboiss

<http://savannah.gnu.org/bugs/download.php?file_id=50224>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59431>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/