[Octave-bug-tracker] [bug #60306] Error running files in a folder containing letters that aren't encoded in system locale

[Markus Mützel]

Update of bug #60306 (project octave):

                  Status:               Postponed => Ready For Test         

    _______________________________________________________

Follow-up Comment #28:

After the changes for bug #60014, we require a Windows API that corresponds to
Windows 7 or newer. That means we are able to use `GetFinalPathNameByHandleW`
now [1].

With that function, it is possible to significantly reduce the complexity of
our implementation of `canonicalize_file_name` on Windows. At the same time,
this also means we are able to solve the locale encoding issue without
requiring C++17 STL functions.

I'd also expect that the new implementation will be more performant than the
existing one because it requires to open a handle to the respective file only
once per function call instead of several times (at least 3 times I would
expect with the previous implementation).

I pushed the change here:
https://hg.savannah.gnu.org/hgweb/octave/rev/d7223245d26f

Marking as ready for test.

[1]:
https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getfinalpathnamebyhandlew

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60306>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/