[Octave-bug-tracker] [bug #60465] [octave forge] (signal) findpeaks should plot data

[anonymous]

URL:
  <https://savannah.gnu.org/bugs/?60465>

                 Summary: [octave forge] (signal) findpeaks should plot data
                 Project: GNU Octave
            Submitted by: None
            Submitted on: Wed 28 Apr 2021 12:23:47 PM UTC
                Category: Octave Forge Package
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Matlab Compatibility
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: 4.2.2
         Discussion Lock: Any
        Operating System: Any

    _______________________________________________________

Details:

If findpeaks has no output it should plot the peaks and the data.

Attached is patch attempt of this.
The plotting works but the data is not suppressed.
The markers are not the same colour. 

Added

  if (nargout == 0)
    plot(data)
    hold on;
    [pks idx] = findpeaks(data);
    scatter(idx, pks,"v", "filled")
  else


Before

if (! (isvector (data) && numel (data) >= 3))
-verbatim+



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 28 Apr 2021 12:23:47 PM UTC  Name: findpeaks.patch  Size: 16KiB  
By: None

<http://savannah.gnu.org/bugs/download.php?file_id=51330>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60465>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/