[Octave-bug-tracker] [bug #61753] Changing assert to panic_impossible

[Arun Giridhar]

Follow-up Comment #9, bug #61753 (project octave):

Here is a WIP patch for libinterp (attached). I used the panic_unless form to
make the search-replace a little easier.

There are build errors with specific locations in stack-frame.cc about not
being able to convert sym to boolean. Not sure how to resolve this. Thoughts?

  CXX      libinterp/corefcn/libcorefcn_la-stack-frame.lo
../libinterp/corefcn/stack-frame.cc:1697:5: error: no matching function for
call to 'panic_unless'
    panic_unless (sym);
    ^~~~~~~~~~~~
../libinterp/corefcn/error.h:512:6: note: candidate function not viable: no
known conversion from 'octave::symbol_record' to 'bool' for 1st argument
void panic_unless (bool cond)
     ^
../libinterp/corefcn/stack-frame.cc:2229:5: error: no matching function for
call to 'panic_unless'
    panic_unless (sym);
    ^~~~~~~~~~~~
../libinterp/corefcn/error.h:512:6: note: candidate function not viable: no
known conversion from 'octave::symbol_record' to 'bool' for 1st argument
void panic_unless (bool cond)
     ^
../libinterp/corefcn/stack-frame.cc:2396:5: error: no matching function for
call to 'panic_unless'
    panic_unless (sym);
    ^~~~~~~~~~~~
../libinterp/corefcn/error.h:512:6: note: candidate function not viable: no
known conversion from 'octave::symbol_record' to 'bool' for 1st argument
void panic_unless (bool cond)
     ^
3 errors generated.



(file #52613)
    _______________________________________________________

Additional Item Attachment:

File name: WIP1_assert.patch              Size:25 KB
    <https://file.savannah.gnu.org/file/WIP1_assert.patch?file_id=52613>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61753>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/