[Octave-bug-tracker] [bug #63063] ode{23, 45} options "Events", "OutputFcn", and "Refine" do not perform correctly.

[Nicholas Jankowski]

Follow-up Comment #20, bug #63063 (project octave):

sorry, i only work with hg at the command line, so don't know the ins and outs
of tortoisehg

comment #18 patch pushes clean on current tip and passes a make check.
original and recent tests appear to run as expected. 

I made a few very minor formatting tweaks (pulling some lines inside 80
characters, splitting AND asserts into two asserts, a few stray whitespace
changes, etc.), and exported a modified patch (attached as
<bug63063_ode2345options_v2.patch>)

I think this is almost ready to push.  

Ken: 
- Can you check where the help docstrings might need to be updated with any
changes. at least i think we'll need to edit odeset's help a little (it still
says Refine is not yet implemented)

- Can you add a brief description of improvements to the /etc/NEWS.8.md file?
This probably fits under the General Improvements section, although possible
Matlab Compatibility, and then include that in the patch?

- I took a stab at a main line commit message, but can you add individual file
details.  for recent multi-file examples see:
http://hg.savannah.gnu.org/hgweb/octave/rev/5330efaf9476
http://hg.savannah.gnu.org/hgweb/octave/rev/1bf26f913b9c

-  right now your name in the commit message is your username from the other
patch.  would you like your name/email in there? (this is what octave
generally compiles it's contributor list from, so it'll appear publicly
however you choose.)

(file #53741)

    _______________________________________________________

Additional Item Attachment:

File name: bug63063_ode2345options_v2.patch Size:30 KB
   
<https://file.savannah.gnu.org/file/bug63063_ode2345options_v2.patch?file_id=53741>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63063>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/