[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #58105] isfield needs time proportional to num
From: |
John W. Eaton |
Subject: |
[Octave-bug-tracker] [bug #58105] isfield needs time proportional to number of fields |
Date: |
Mon, 3 Oct 2022 10:05:28 -0400 (EDT) |
Follow-up Comment #11, bug #58105 (project octave):
Normally we try to limit changes in the stable release series to documentation
and fixes for regressions or serious incorrect results. Performance
improvements wouldn't usually be included in a bug fix release.
As for the current proposed patch, we don't normally use C-style casts, and I
can't think of any other places in Octave where we bother with "(void)" casts
on return types.
Also, I think a "catch (...)" block to ignore all possible exceptions is bad
form unless there is a very good reason for using it. Why is it needed here?
If the performance of octave_map::isfield is bad, we should fix that problem
rather than using the method proposed in this patch.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?58105>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/