[Octave-bug-tracker] [bug #63210] Lots of warnings in compilation

[anonymous]

Follow-up Comment #4, bug #63210 (project octave):

Chganging | with || and & with && elimintaes the warngins.

diff -r 6408e371355b libgui/src/m-editor/file-editor-tab.cc
--- a/libgui/src/m-editor/file-editor-tab.cc    Sat Oct 15 18:46:55 2022
+0200
+++ b/libgui/src/m-editor/file-editor-tab.cc    Sat Oct 15 19:43:11 2022
-0400
@@ -1044,7 +1044,7 @@ namespace octave
     if (ID != this)
       return;
 
-    if (m_edit_area->isModified () | ! valid_file_name ())
+    if (m_edit_area->isModified () || ! valid_file_name ())
       {
         save_file (m_file_name);  // save file dialog
 
diff -r 6408e371355b liboctave/operators/mx-inlines.cc
--- a/liboctave/operators/mx-inlines.cc Sat Oct 15 18:46:55 2022 +0200
+++ b/liboctave/operators/mx-inlines.cc Sat Oct 15 19:43:11 2022 -0400
@@ -213,12 +213,12 @@ inline void mx_inline_not2 (std::size_t 
       r[i] = xx OP (NOT2 logical_value (y[i]));                         \
   }
 
-DEFMXBOOLOP (mx_inline_and, , &, )
-DEFMXBOOLOP (mx_inline_or, , |, )
-DEFMXBOOLOP (mx_inline_not_and, !, &, )
-DEFMXBOOLOP (mx_inline_not_or, !, |, )
-DEFMXBOOLOP (mx_inline_and_not, , &, !)
-DEFMXBOOLOP (mx_inline_or_not, , |, !)
+DEFMXBOOLOP (mx_inline_and, , &&, )
+DEFMXBOOLOP (mx_inline_or, , ||, )
+DEFMXBOOLOP (mx_inline_not_and, !, &&, )
+DEFMXBOOLOP (mx_inline_not_or, !, ||, )
+DEFMXBOOLOP (mx_inline_and_not, , &&, !)
+DEFMXBOOLOP (mx_inline_or_not, , ||, !)
 
 template <typename X>
 inline void


Remiainging wwanringrs:

In file included from ../libinterp/corefcn/oct-stream.cc:44:
In file included from ../libinterp/corefcn/Cell.h:36:
In file included from ../libinterp/octave-value/ov.h:67:
../libinterp/corefcn/oct-stream.h:217:47: warning: private field 'm_converter'
is not used [-Wunused-private-field]
    std::wbuffer_convert<convfacet_u8, char> *m_converter;
                                              ^
1 warning generated.


../libgui/src/m-editor/octave-qscintilla.cc:1044:9: warning: lambda capture
'this' is not used [-Wunused-lambda-capture]
      ([this, dbg, auto_repeat] (interpreter& interp)
        ^~~~~
1 warning generated.


But wanrinikg can also be suprrepessed.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63210>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/