[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #63229] Missing self test for option OutputSel
From: |
Nicholas Jankowski |
Subject: |
[Octave-bug-tracker] [bug #63229] Missing self test for option OutputSel in ode23, ode23s, ode45 |
Date: |
Wed, 16 Nov 2022 23:13:25 -0500 (EST) |
Update of bug #63229 (project octave):
Originator Name: => Ken Marek
_______________________________________________________
Follow-up Comment #7:
ok. I played around with it a bit, I also didn't see a better way to test
that functionality than how you did it. all 6 asserts get hit in the tests you
created, so I don't think it's any messier than the rest of the tests in those
functions.
the only changes I made were to divide up the test block into 3 individual
test blocks. this will make it a bit clearer which block is creating the error
if one occurs.
adjusted patch attached. passes all tests, and I remembered to keep your name
on it :)
Requesting someone else push it if it looks good, though. It's just a BIST
change and should be fairly low impact, but I'm not sure where things are
right now in the current state of octave 8 release after the branches were
merged.
(file #53967)
_______________________________________________________
Additional Item Attachment:
File name: OutputSeltest_bug63229_v2.patch Size:6 KB
<https://file.savannah.gnu.org/file/OutputSeltest_bug63229_v2.patch?file_id=53967>
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?63229>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #63229] Missing self test for option OutputSel in ode23, ode23s, ode45, Ken Marek, 2022/11/16
- [Octave-bug-tracker] [bug #63229] Missing self test for option OutputSel in ode23, ode23s, ode45, Nicholas Jankowski, 2022/11/16
- [Octave-bug-tracker] [bug #63229] Missing self test for option OutputSel in ode23, ode23s, ode45, Ken Marek, 2022/11/16
- [Octave-bug-tracker] [bug #63229] Missing self test for option OutputSel in ode23, ode23s, ode45, Nicholas Jankowski, 2022/11/16
- [Octave-bug-tracker] [bug #63229] Missing self test for option OutputSel in ode23, ode23s, ode45,
Nicholas Jankowski <=
- [Octave-bug-tracker] [bug #63229] Missing self test for option OutputSel in ode23, ode23s, ode45, Ken Marek, 2022/11/17
- [Octave-bug-tracker] [bug #63229] Missing self test for option OutputSel in ode23, ode23s, ode45, Nicholas Jankowski, 2022/11/17
- [Octave-bug-tracker] [bug #63229] Missing self test for option OutputSel in ode23, ode23s, ode45, Nicholas Jankowski, 2022/11/17
- [Octave-bug-tracker] [bug #63229] Missing self test for option OutputSel in ode23, ode23s, ode45, John W. Eaton, 2022/11/21