[Octave-bug-tracker] [bug #61370] gcc's thread sanitizer reports several race conditions

[Markus Mützel]

Follow-up Comment #17, bug #61370 (project octave):

Reading through the thread, there are two points which I couldn't see if they
are addressed in the updated patch:
- `extern OCTAVE_API std::atomic<sig_atomic_t> octave_interrupt_state;` should
be replaced by `extern OCTAVE_API std::atomic<int> octave_interrupt_state;`.
That seems to have been agreed on.
- `quit.h` in a public header. Is it ok to move octave_interrupt_state to a
block where it is no longer declared for C programs?

Wrt the second point: A Google search for `octave_interrupt_state` didn't
result in a single hit in a C source file. That doesn't necessarily mean that
there isn't code out the that uses it in C. But I'd guess that is pretty
unlikely.

>From my point of view, this could go on stable when the first point is fixed.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61370>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/