[Octave-bug-tracker] [bug #64853] Misc bytecode interpreter fixes

[Petter]

URL:
  <https://savannah.gnu.org/bugs/?64853>

                 Summary: Misc bytecode interpreter fixes
                   Group: GNU Octave
               Submitter: petter
               Submitted: Sat 04 Nov 2023 12:41:52 AM UTC
                Category: Interpreter
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: None
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: dev
         Discussion Lock: Any
        Operating System: GNU/Linux
           Fixed Release: None
         Planned Release: None


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Sat 04 Nov 2023 12:41:52 AM UTC By: Petter <petter>
32551:

Change some printf to cout

According to coding guidelines. Some printf:es are left
till std::format C17++ can be used.

* pt-bytecode-vm.cc: printf -> cout

32552:

Set uninitialized m_ip field

The field was not set during some circumstances
which could potentially give the wrong line number in
warnings and errors from the bytecode interpreter.

* stack-frame.cc: Default init to 0.

32553:

Do type check before static_cast to wrong type

The virtual function is_defined() was called on a pointer to
octave_cached_value
, when the object actually was a octave_base_value. The type check call need
to
be done on a pointer to the base class to be standard compliant.

* pt-bytecode-vm.cc: Comply

32554:

Replace public field with getter setter

Follow coding guidelines for m_compilation_failed.

* ov-usr_fcn.h: Def getter setter, hide field
* pt-bytecode-vm.cc: Use getter setter
* ov-fcn-handle.cc: Use setter








    _______________________________________________________
File Attachments:


-------------------------------------------------------
Date: Sat 04 Nov 2023 12:41:52 AM UTC  Name: octave_32551.patch  Size: 10KiB  
By: petter

<http://savannah.gnu.org/bugs/download.php?file_id=55301>
-------------------------------------------------------
Date: Sat 04 Nov 2023 12:41:52 AM UTC  Name: octave_32553.patch  Size: 2KiB  
By: petter

<http://savannah.gnu.org/bugs/download.php?file_id=55302>
-------------------------------------------------------
Date: Sat 04 Nov 2023 12:41:52 AM UTC  Name: octave_32552.patch  Size: 911B  
By: petter

<http://savannah.gnu.org/bugs/download.php?file_id=55303>
-------------------------------------------------------
Date: Sat 04 Nov 2023 12:41:52 AM UTC  Name: octave_32554.patch  Size: 2KiB  
By: petter

<http://savannah.gnu.org/bugs/download.php?file_id=55304>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?64853>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/