[Octave-bug-tracker] [bug #65200] Special nil octave_base_value class to speed up octave_value dtors

[John W. Eaton]

Update of bug#65200 (group octave):

                  Status:          Ready For Test => In Progress            

    _______________________________________________________

Follow-up Comment #4:

What review?

Before pushing changes that will eventually affect more than just the bytecode
interpreter, we need to have some actual review of the code before we make a
decision about whether it to accept it.  And, if accepted, the changes should
probably go on default.  I'd rather make that decision now instead of waiting
until we someday merge the bytecode interpreter branch back to default, at
which point we will probably have forgotten about these changes and won't
remember to check whether they are really appropriate for all of Octave or
just for the bytecode interpreter.

Even for code that is just in the bytecode interpreter files, we probably need
more review than we have been doing.

Maybe we do want this change to the way we handle octave_value::nil_rep, but
until we have some discussion about it, I've backed out the changes.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65200>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/