octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #65176] unique.m - Enable third output with op


From: Nicholas Jankowski
Subject: [Octave-bug-tracker] [bug #65176] unique.m - Enable third output with option 'stable'
Date: Fri, 23 Feb 2024 14:22:56 -0500 (EST)

Follow-up Comment #14, bug#65176 (group octave):

new patch removes all calls to sort after the initial one for y. reordered 2nd
and 3rd output calculations to utilize i output to simplify calculating j
without redundancy. This still has the find(u(s) == l(j)') 2d expansion which
i have noted with a FIXME does cause a memory usage increase (largest internal
variable goes from n to m x n where m is the number of unique elements in x)
which could be an issue for large data sets, in addition to using the
two-output form of find which imposes a ~10-25% slowdown on larger data. 

But, this seems to be at a pretty good state.  I'll maybe take a bit more time
to see if there's a better final replacement to that 2d expansion, otherwise
I'll push it to default for test.

(file #55736)

    _______________________________________________________

Additional Item Attachment:

File name: unique_stable_bug65176_v8.patch Size:8 KB
   
<https://file.savannah.gnu.org/file/unique_stable_bug65176_v8.patch?file_id=55736>


    AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://git.savannah.nongnu.org/cgit/administration/savane.git/snapshot/savane-48ddd5e09ff68675481700a041ae2602dfa85a16.tar.gz


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65176>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]