[Octave-bug-tracker] [bug #66399] fseek and ftell functions don't always work correctly on Win11 with filesizes >2GB

[Markus Mützel]

Follow-up Comment #12, bug #66399 (group octave):

Thank you for re-uploading the patch.

We usually are treating the files in `libgui/qterminal/libqterminal/unix` as
"upstream" and try to avoid touching them if not needed.
They are not used when building for Windows. And if I understand correctly,
the FILE pointers are pipes in that case.
Should we also avoid to use `fseek` with pipes?

Is `std::fseeko` a part of the C++ standard? Does gnulib also add or replace
functions in the `std` namespace?
We generally try to avoid including headers from gnulib directly in C++
sources. (I don't know the exact background. But I seem to recall that it
caused issues in some cases in the past.)
Instead, we wrap around gnulib functions in small C objects and call these
wrapper functions from C++ code. You'll find, e.g,. `octave_ftello_wrapper` or
`octave_fseeko_wrapper` where that is done.
I can try to do that for the changes you proposed for `gl2ps-print.cc`.

I was searching the code base for `fseek` and `ftell`. But I couldn't find
places other than the ones you pointed out in your patch where they are used.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?66399>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc
Description: PGP signature