Re: Octave Coder __ A code generator and build system that converts Octave to C++

[Hossein Sajjadi]

On 6/5/20, Hossein Sajjadi <sajjadi.floss@gmail.com> wrote:
> Carlo,
> Sorry for late reply. It is my first experience with github.
>
> On 6/5/20, Carlo De Falco <carlo.defalco@polimi.it> wrote:
>> Hi,
>>
>>> Il giorno 4 giu 2020, alle ore 22:46, Hossein Sajjadi
>>> <sajjadi.floss@gmail.com> ha scritto:
>>>
>>> Thanks, Carlo
>>> Bugs fixed. versions 4.4.1 , 5.1.1 and 5.2.1 released.
>>>
>>
>> I just created a pull request on GitHub to fix more clang errors and
>> warnings,
>> but I still see the following warnings you may want to handle :
>>
>>
>> OctaveCoder/src/code_generator.cpp:448:15: warning: enumeration values
>> 'num_binary_ops'
>>       and 'unknown_binary_op' not handled in switch [-Wswitch]
>>       switch (etype)
>>               ^
>> OctaveCoder/src/code_generator.cpp:448:15: note: add missing switch cases
>>       switch (etype)
>>               ^
>> OctaveCoder/src/code_generator.cpp:591:15: warning: enumeration values
>>       'num_compound_binary_ops' and 'unknown_compound_binary_op' not
>> handled
>> in switch [-Wswitch]
>>       switch (etype)
>>               ^
>> OctaveCoder/src/code_generator.cpp:591:15: note: add missing switch cases
>>       switch (etype)
>>               ^
>> OctaveCoder/src/code_generator.cpp:1740:17: warning: 5 enumeration values
>> not handled in
>>       switch: 'op_not', 'op_uplus', 'op_uminus'... [-Wswitch]
>>         switch (etype)
>>                 ^
>> OctaveCoder/src/code_generator.cpp:1740:17: note: add missing switch
>> cases
>>         switch (etype)
>>                 ^
>> OctaveCoder/src/code_generator.cpp:1772:17: warning: 4 enumeration values
>> not handled in
>>       switch: 'op_transpose', 'op_hermitian', 'num_unary_ops'...
>> [-Wswitch]
>>         switch (etype)
>>                 ^
>> OctaveCoder/src/code_generator.cpp:1772:17: note: add missing switch
>> cases
>>         switch (etype)
>>                 ^
>> OctaveCoder/src/code_generator.cpp:1824:17: warning: enumeration values
>> 'num_assign_ops'
>>       and 'unknown_assign_op' not handled in switch [-Wswitch]
>>         switch (etype)
>>                 ^
>> OctaveCoder/src/code_generator.cpp:1824:17: note: add missing switch
>> cases
>>         switch (etype)
>>                 ^
>> 5 warnings generated.
>>
>>
>> and also :
>>
>> pippo.cc:3775:45: warning: relational comparison result unused
>> [-Wunused-comparison]
>>               for (octave_idx_type i = k; i < nel, j < nargout_retval;
>> i++)
>>
>>
>>
>> which comes from line 3785 in "coder_runtime.cpp"
>>
>>
>> c.
>>
>>
>>
>
>
> --
>
> Sincerely,
> Hossein
>


-- 

Sincerely,
Hossein

Carlo, sorry for late reply.
Thank you for your extended review and bug fixes.
For the error related to -gtoggle I have changed it to -g0. My current
plan is to support all versions of Octave from 4.4.0. I have read some
threads that recommended to push changes in the oldest branch ,here is
branch 4, and merge changes to newer branches. However your changes is
in branch 'dev' . I 'm not sure what should I do.