[Octave-patch-tracker] [patch #10102] [octave forge] (statistics) Add new functions ismissing and rmmissing

[Philip Nienhuis]

Follow-up Comment #1, patch #10102 (project octave):

Thanks ilguido.

These are core Matlab functions (since r2013a) and so I think they should go
into core.

I wonder why rmmissing.m contains a switch statement where an if/elseif block
would suffice; is it to be able to extend to string classes, if ever
implemented in core Octave?

Additionally I think there's no harm in extending beyond Matlab compatibility;
I can see use cases for mixed-type cell arrays (e.g., output of csv2cell() or
xlsread.m and the like).

For core Octave some more rigor is required. Adding BIST for real operations
rather than just error checks is imperative. There are also some slight style
things (core devs are a bit strict), e.g. single quotes around a text in a
case condition in rmmissing; empty line before endfunction; and I'm unsure of
the texinfo.
The copyright owner would be "The Octave Project Developers" but you'd me
mentioned as author in the Mercurial log so eternal fame would be preserved.
I hope you'll agree with this.

For core Octave (and actually the statistics package as well) we use Mercurial
rather than git. But if you would first improve ismissing and rmmissing I'll
help in producing a mercurial cset.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10102>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/