[Octave-patch-tracker] [patch #10321] Communications package : Implementation of ssbmod

[John Donoghue]

Follow-up Comment #1, patch #10321 (project octave):

Thanks for the contribution, I tagged the communications maintainer.


Just a quick look at the file in terms of visual rather than functionality a
few comments:


Your copyright has a bad year 20203


The texinfo has some issues I think, type help ssbmod, to show the texingo as
a user would see.

The additional function definitions after the initial deftypefn should be
deftypefnx.

Instead of calling the optional varargin{1} and {2} in the documentation, use
the actual functional name of the variable.

the varargs are also outside you inputs list currently.

You dont need to add basically the same documentation as a comment after the
help text - if there is any additional information in it, include it in the
help text (references etc)


The function has some test or demo comments at the bottom? but are not in a
test block.


  


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10321>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/