Re: [Octave-patch-tracker] [patch #9000] Polygon functions for geometry/mapping package

[Juan Pablo Carbajal]

On Sat, Sep 3, 2016 at 11:36 PM, Philip Nienhuis
<INVALID.NOREPLY@gnu.org> wrote:
> Follow-up Comment #19, patch #9000 (project octave):
>
> JuanPi and Amr:
> Just to let you know that I picked up integrating Amr's contribution into the
> geometry/mapping packages. I think most of it should go in geometry.
>
> @JuanPi: I didn't know that you had already absorbed some of my contributions
> in the geometry package, thanks for that. (I found out through perusing the
> log of Amr's code on bitbucket.org.)
>
> In the next days /weeks I'll send a few comments / suggestions; I've almost
> finished my "review" of Amr's work from package maintainer's POV. Hopefully I
> do not step (too much) on your territory, JuanPi :-)
>
Go ahead and merge, we can alsways interate further once the material
is in the repo and working.
I will try to catch up as soon as I can...currently, swamped.

> - Almost all functions need fixes for octave coding style
>
Let's do that afterwards the things are running.
You should open a branch (maybe a bookmark) for this update.

> - polybool etc only works with boost-1.60 while currently boost-1.61 is
> current. In spite of what John Swensen apparently interpreted, boost-1.60
> features self-intersection well.
>
if boost is not present, do we loose some functions. If thatis thecae
then we might need to adapt the makefile to use Carnë's trick to avoid
providing useless functions.

>
>     _______________________________________________________
>
> Reply to this item at:
>
>   <http://savannah.gnu.org/patch/?9000>
>
> _______________________________________________
>   Message sent via/by Savannah
>   http://savannah.gnu.org/
>