Re: One empty line too much before multipart-body?

[Aymeric Moizard]

Hi Roger,

Thanks for the patch.

I'm not using multipart often, and I believe bugs may still be around.

I would like to have more information about the issue in order to exactly

understand it. I'm concerned about making a change I don't understand.

I've never seen myself with 2 empty lines, so can you consider sending me code, network capture

or simple txt message showing the issue?

Regards,

Aymeric

Le mar. 16 janv. 2024 à 02:03, Roger Schreiter <roger@planinternet.de> a écrit :

Hello,

when generating a SIP request including a multipart body, I can see 2 empty lines between header and body, i.e. a series of 3 times CRLF.

Imho 2x CRLF would be correct, which is 1 empty line between header and body.

May anyone have a look into the attached diff file for
libosip2-5.3.1/src/osipparser2/osip_message_to_str.c
which imho solves the problem and generates the correct request.

Regards, Roger.

-- 
Roger Schreiter
Lutherstr. 9
D-71576 Burgstetten
Tel.: +49 7191 8929678

--

Antisip - http://www.antisip.com