Re: [Pan-devel] PATCH to close cache files before unlinking

[John Morris]

I'll give the patch a spin and see what happens.

I take it you want me to try this without my change?

No, I'm not the John Morris you knew. It's a pretty common name, so
there are quite a few of me running around out there.

Thanks

John



On Thu, 2002-09-19 at 14:06, Charles Kerr wrote:
> On Thu, Sep 19, 2002 at 03:12:45AM -0500, John Morris wrote:
> 
> > I just joined the mailing list, and I have a patch for a problem I had
> > with Pan 0.13.0.90.
> > 
> > I was having problems with Pan running out of file descriptors when
> > downloading a large amount of binaries, and "lsof" showed that all the
> > cache files were being opened, but never closed, even after unlinking.
> > 
> > So, I made the change I'm attaching, and all is now well.
> 
> Hi John,
> 
> You're right, there is a fd leak here.  However the gmime_stream_file
> object _should_ be fclosing these files themselves, so even with your
> patch there is still a huge GMimeMessage leak lurking around.
> 
> Could you give this patch a spin for me:
> http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan/base&command=DIFF_FRAMESET&file=util-mime.c&rev1=1.42&rev2=1.43&root=/cvs/gnome
> 
> cheers,
> Charles
> 
> PS.  You wouldn't be the John Morris I once knew in OKC, would you?
> 
> 
> _______________________________________________
> Pan-devel mailing list
> address@hidden
> http://mail.freesoftware.fsf.org/mailman/listinfo/pan-devel
>