[Pan-devel] Re: Re: Pan 0.92... my first impressions

[Motor]

On Sun, 09 Apr 2006 10:48:02 -0500, Charles Kerr wrote:

>> On Sun, 09 Apr 2006 14:57:06 +0100, Motor wrote:
>>
>>> My old score file seems to cause it to crash. I've tracked it down to
>>> a problem with entries using "Xref:". I noticed that someone else
>>> mentioned this, so I'll leave it for now.
> 
> Attached is the patch.--- pan/data-impl/article-filter.cc.bak +++
> pan/data-impl/article-filter.cc

Thanks. That seems to be working... at least pan isn't crashing out when
the group is selected now. I'll keep an eye on it to see if it is working
correctly. However, messing about with this has brought another problem to
light.


This Score entry (created by an older version of Pan's Ignore Thread)
causes problems:

%BOS
%Score created by Pan on Sun Mar 12 01:11:04 2006

[rec.arts.tv, rec.arts.sf.tv, rec.arts.startrek.current,
alt.tv.smallville, alt.tv.stargate-sg1] Score:: =-9999 % ignore thread
"Re: MPAA is a Bunch of Gas Bags and I do not give a Crap about their
Crackdown, so, SHUTUP" Expires: 4/12/2006
        Message-Id:
        ^<address@hidden>$
        References:
        ^<address@hidden>
%EOS

I think it's the "References" header, because when I experimented with
creating a Score from within pan 0.92 and chose to filter on the
References header... I had the same crash.

Here's a backtrace:

pan: article-filter.cc:47: pan::StringView<unnamed>::get_header(const
pan::Article&, const pan::Quark&): Assertion `0 && "I don't know that
header!"' failed.

Program received signal SIGABRT, Aborted. [Switching to Thread -1208797520
(LWP 13026)] 0x001f0210 in raise () from /lib/libc.so.6 (gdb) bt #0 
0x001f0210 in raise () from /lib/libc.so.6 #1  0x001f15ec in abort () from
/lib/libc.so.6 #2  0x001e9f0e in __assert_fail () from /lib/libc.so.6 #3 
0x080dbf79 in (anonymous namespace)::get_header (address@hidden,
address@hidden)
    at article-filter.cc:47
#4  0x080dc641 in pan::ArticleFilter::test_article (address@hidden,
address@hidden,
    address@hidden) at article-filter.cc:121
#5  0x080dc3ba in pan::ArticleFilter::test_article (address@hidden,
address@hidden,
    address@hidden) at article-filter.cc:78
#6  0x080dcdfb in pan::ArticleFilter::score_article (address@hidden,
address@hidden,
    address@hidden) at article-filter.cc:206
#7  0x080b8ec6 in pan::DataImpl::load_headers (this=0xbff5c2c8,
address@hidden,
    address@hidden) at headers.cc:368
#8  0x080b9ff7 in pan::DataImpl::ref_group (this=0xbff5c2c8,
address@hidden) at headers.cc:124 #9  0x080d25ac in MyTree
(this=0x8bb7c60, address@hidden, address@hidden)
    at my-tree.cc:134
#10 0x080affe0 in pan::DataImpl::group_get_articles (this=0xbff5c2c8,
address@hidden,
    criteria=0x8abb328) at headers.cc:931
#11 0x08071849 in pan::HeaderPane::set_group (this=0x8abb2f8,
address@hidden)
    at header-pane.cc:541
#12 0x08059191 in pan::GUI::do_read_selected_group (this=0xbff5c164) at
gui.cc:899 #13 0x00da01c9 in g_cclosure_marshal_VOID__VOID () from
/usr/lib/libgobject-2.0.so.0 #14 0x00d92f6d in g_closure_invoke () from
/usr/lib/libgobject-2.0.so.0 #15 0x00da3a3d in
g_signal_override_class_closure () from /usr/lib/libgobject-2.0.so.0 #16
0x00da4f47 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#17 0x00da5109 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 #18
0x03402255 in gtk_accessible_connect_widget_destroyed () from
/usr/lib/libgtk-x11-2.0.so.0 #19 0x034030f8 in gtk_action_activate () from
/usr/lib/libgtk-x11-2.0.so.0 #20 0x08069edc in (anonymous
namespace)::on_row_activated_idle (pane_g=0x8605200)
    at group-pane.cc:206
#21 0x00d196e1 in g_list_remove_link () from /usr/lib/libglib-2.0.so.0 #22
0x00d1b09d in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#23 0x00d1e32f in g_main_context_check () from /usr/lib/libglib-2.0.so.0
#24 0x00d1e6d9 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
---Type <return> to continue, or q <return> to quit--- #25 0x034d7594 in
gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 #26 0x0805fd23 in (anonymous
namespace)::run_pan_in_window (address@hidden, address@hidden,
    address@hidden, address@hidden, window=0x85da848) at pan.cc:98
#27 0x0806065c in main (argc=Cannot access memory at address 0x0 ) at
pan.cc:234